[C-API] Add struct list_entry, ListVector::reserve and ListVector::set_size #6155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @Tishj, the GHA failure seems to be irrelevant. Would you mind to help to re-trigger the jobs? Thanks! |
|
Thanks for the PR! Looks good. Could we perhaps also add some tests to |
Tishj
reviewed
Feb 9, 2023
src/main/capi/data_chunk-c.cpp
Outdated
| @@ -128,6 +128,22 @@ idx_t duckdb_list_vector_get_size(duckdb_vector vector) { | |||
| return duckdb::ListVector::GetListSize(*v); | |||
| } | |||
|
|
|||
| void duckdb_list_vector_set_size(duckdb_vector vector, idx_t size) { | |||
| if (!vector) { | |||
| return; | |||
There was a problem hiding this comment.
Since this doesn't have a desired return value, could we perhaps make it a duckdb_state so we can indicate that the input was faulty instead of silently returning?
Same goes for the duckdb_list_vector_reserve
|
Thanks for the fixes! It looks like the newly added test is failing, however. Could you have a look? |
|
@Mytherin yes, sorry was busy last few days. i will keep working on this to get it through. |
|
@Mytherin could you take a look? The ODBC build failure is not relevant. |
|
Thanks! |
dacort
added a commit
to dacort/lance
that referenced
this pull request
Feb 18, 2023
A few changes were made in v0.7.0 of duckdb that impacted this extension: - list_vector changes were merged in duckdb/duckdb#6155 - JSON type was removed duckdb/duckdb#6288 - Some function signatures were changedd
changhiskhan
pushed a commit
to lancedb/lance
that referenced
this pull request
Feb 18, 2023
* Fixes #567 A few changes were made in v0.7.0 of duckdb that impacted this extension: - list_vector changes were merged in duckdb/duckdb#6155 - JSON type was removed duckdb/duckdb#6288 - Some function signatures were changedd * Trigger Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows construct and modify a
ListVectorfrom the C API, as well as the integration from other languages, i.e., Rust.The motivation was discussed in #6152