Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzer fixes 2, 3 and 5 of #5984 #6187

Merged
merged 6 commits into from
Feb 11, 2023

Conversation

samansmink
Copy link
Contributor

This PR resolves issues 2, 3 and 5 of #5984

2: Percentile value should be between 0 and 1, NaN was not handled and would make stuff crash
3: strcpy of a non-null terminated string would cause problems, needed some minor gymnastics to avoid clang-tidy complaining as it doesn't like when you don't null terminate what looks like a c string.

5: Continuation of #5267. In that PR the issue appeared to be fixed, but it was hidden due to the fact the query_verification pragma in the test messes with the aliasing. I resolved this by removing the custom error message (as it was actually both having false positives as not working when aliased) and passing row_id = false to AddBaseTable.

@Mytherin Mytherin merged commit 1540ddd into duckdb:master Feb 11, 2023
@Mytherin
Copy link
Collaborator

Thanks! LGTM

@PedroTadim
Copy link
Contributor

The second part of issue 2 has not yet been fixed:

SELECT percentile_disc([]) WITHIN GROUP (ORDER BY LAST);

ABORT THROWN BY INTERNAL EXCEPTION: Value::LIST without providing a child-type requires a non-empty list of values. Use Value::LIST(child_type, list) instead

@samansmink
Copy link
Contributor Author

good catch @PedroTadim, I missed that, will send a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants