Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issues 2, 3 and 5 of #5984
2: Percentile value should be between 0 and 1, NaN was not handled and would make stuff crash
3: strcpy of a non-null terminated string would cause problems, needed some minor gymnastics to avoid clang-tidy complaining as it doesn't like when you don't null terminate what looks like a c string.
5: Continuation of #5267. In that PR the issue appeared to be fixed, but it was hidden due to the fact the query_verification pragma in the test messes with the aliasing. I resolved this by removing the custom error message (as it was actually both having false positives as not working when aliased) and passing row_id = false to AddBaseTable.