bugfix(python): fsspec file modes #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mause
commented
Feb 11, 2023
| @@ -0,0 +1,13 @@ | |||
| # name: test/sql/attach/attach_fsspec.test | |||
There was a problem hiding this comment.
@Mytherin I wasn't able to get these tests to run locally unfortunately, not sure if there's a trick to it? Some list they need to be added to?
There was a problem hiding this comment.
They are automatically added - but you need to run the unittest program from the root directory, e.g.:
build/debug/test/unittest test/sql/attach/attach_fsspec.test
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow attaching remote databases over fsspec