Preserving replacement_open functionality #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Feb 24, 2023
src/include/duckdb/main/config.hpp
Outdated
| @@ -146,6 +146,8 @@ struct DBConfigOptions { | |||
| bool immediate_transaction_mode = false; | |||
| //! The set of unrecognized (other) options | |||
| unordered_map<string, Value> unrecognized_options; | |||
| //! storage_init extension hook is used only for configuration and does not provide a storage_extension | |||
| bool extension_init_is_config_only = false; | |||
There was a problem hiding this comment.
Having this be a global option means we cannot use extensions that provide a storage back-end (e.g. SQLite) together with extensions that do not. Perhaps we could instead check if the given storage extension provides the attach and create_transaction_manager functions?
…storage_extension
…storage_extension
…to config-workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MotherDuck's next release, we are transitioning from replacement_open to storage_init. However, we don't want to introduce a full-blown storage extension yet. This PR allows us the storage_init as a config-only replacement hook (preserving the previous functionality...as a stepping stone in our transition).