Enhance the generation of random floating point by PCG #7842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed a unit test, relying on a particular seed value. |
Mytherin
approved these changes
Jun 6, 2023
|
I'm glad to hear that the Pull Request looks good to you. If there are any additional changes needed, feel free to let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously implemented method of creating a random integer then dividing it by std::numeric_limits<uint32_t>::max() results in a distribution that is not truly uniform.
A more robust method for generating a random floating number :
double d = ldexp(pcg32_random_r(&myrng), -32);This is the method recommended in PCG documentation.
For further explanation why the existing approach yields suboptimal results here.