-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casts from and to BIT
type
#7941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
It looks really good, I just had a few comments, after those are addressed I think it's good to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, I think it's nearly ready to be merged.
I did have one small comment that I missed earlier
@Tishj is this PR good to go? |
Thanks @nickgerrets, well done! |
Solves #7640
Adds casting from numeric types,
BOOLEAN
type andBLOB
type toBIT
type and vice versa.List of added casts:
From bit to numerical types will throw an exception if there is not enough space to hold all the bits. From bit to boolean will convert the boolean value to become either 1 or 0 (true or false).