Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #7852: Window Vectorisation #8050

Merged
merged 7 commits into from Jun 26, 2023
Merged

Issue #7852: Window Vectorisation #8050

merged 7 commits into from Jun 26, 2023

Conversation

hawkfish
Copy link
Contributor

  • Reuse tree aggregations between frames.
  • Reduce fan-out from 64 to recommended 16.
  • Fix intitialisation without combine. (Another victory for vector size 2.)

Performance gains:

Change Time (s)
Baseline 14.817
Reuse 10.031
Fan Out 8.350

Richard Wesley added 5 commits June 21, 2023 09:14
Issue duckdb#7852: Window Vectorisation
96eca5d 
Reuse tree aggregations between frames.
Merge branch 'feature' into window-reuse
ac78169
Issue duckdb#7852: Window Vectorisation
86a527b 
Reduce fan-out from 64 to recommended 16.
Drops benchmark from 10.031s to 8.350s.
Issue duckdb#7852: Window Vectorisation
915b55f 
Fix intitialisation without combine.
Another victory for vector size 2.
[Dev]: Fix pointless std::move
548bab5 
Breaks my OSX so I'm fixing it too.
@hawkfish hawkfish requested a review from Mytherin June 22, 2023 16:01
@hawkfish
Copy link
Contributor Author

Viktor and I also profiled the two changes independently.

Fan Out No Reuse Reuse Gain
16 10.654 8.350 127%
64 14.817 10.031 147%
Gain 139% 120%  

Mytherin
Mytherin reviewed Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM - small comment:

test/sql/window/test_parallel_window.test_slow Show resolved Hide resolved
src/execution/window_segment_tree.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft June 24, 2023 21:38
@Mytherin Mytherin marked this pull request as ready for review June 25, 2023 08:33
@Mytherin Mytherin merged commit aada97e into duckdb:feature Jun 26, 2023
53 of 54 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@hawkfish hawkfish deleted the window-reuse branch June 26, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Mytherin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hawkfish @Mytherin