capi: duckdb_interrupt & duckdb_query_progress #8064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Virgiel We changed slightly the way CI works, instead of triggering CI on any change now changes automatically classify any PR as "draft" and you have to say "ready for review" (clicking via web UI) to get a go at the CI. I will add soon some documentation. |
|
I am not sure these functions need to be tested, as they are already tested elsewhere. I got the progress from the connection as it was only publicly accessible there, but it might make more sense to get it from the pending result. |
|
We would prefer if they are tested yes - could you add tests to the C API test suite? |
|
Thanks! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces two C functions to interrupt queries and get queries progress