Skip failing test on R on CI #8161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem found by @Tmonster, that's also working on a fix. Ugly patch with nonsensical import is intended to be temporary.
|
Thanks! |
|
The failing tests actually flagged a problem that now CRAN is yelling at us for as well - maybe next time we should not just skip them |
krlmlr
pushed a commit
to krlmlr/duckdb
that referenced
this pull request
Aug 21, 2023
Skip failing test on R on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem found by @Tmonster, that's also looking for a fix.
Ugly patch with nonsensical import is intended to be very temporary.
I guess this is an is an alternative to the first commit of #8155 that's more limited in scope. Works on my fork (!), I'd say ready to go on my side.