Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODBC: Reformat Diagnosics Function #8237

Merged
merged 8 commits into from
Jul 14, 2023
Merged

ODBC: Reformat Diagnosics Function #8237

merged 8 commits into from
Jul 14, 2023

Conversation

maiadegraaf
Copy link
Contributor

Small reformatting that simplifies the calling of the diagnostics function, shouldn't change any functionality.

Also in a previous PR when reformating OdbcFetch::RowWise I accidentally passed nullptr instead of hstmt. This is fixed now.

@Mytherin Mytherin merged commit ea57bf0 into duckdb:master Jul 14, 2023
21 checks passed
@Mytherin
Copy link
Collaborator

Thanks! LGTM

@maiadegraaf maiadegraaf deleted the ODBC_diagnostic_record_reformat branch October 6, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maiadegraaf @Mytherin