Reduce colreaders #8248
Merged
Reduce colreaders #8248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 6, 2023 17:07
# Conflicts: # extension/parquet/parquet_reader.cpp
- remove debug test
Mytherin
reviewed
Jul 14, 2023
| @@ -399,7 +399,6 @@ void ParquetReader::InitializeSchema() { | |||
| if (file_meta_data->schema.size() < 2) { | |||
| throw FormatException("Need at least one non-root column in the file"); | |||
| } | |||
| auto root_reader = CreateReader(); | |||
There was a problem hiding this comment.
Can this not stay in the InitializeSchema? It seems like we are initializing the root_reader only right before calling InitializeSchema anyway.
There was a problem hiding this comment.
That's right, moved it to InitializeSchema(). Thanks!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReadStatistics call was creating a root_reader for every column, now we do this only once at initialization.
This reduces the number of creations by the amount of columns (PropagateStatistics does this for all columns)