Issue #8086: Parallel Window Refactoring #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
June 26, 2023 15:20
Basic code motion to refactor WindowExecutor into smarter, purpose-built subclasses.
`WindowCumeDistExecutor` does not need `NextRank`
Convert rank and dense_rank to compute their state at the start of each block This will allow them to be called on multiple threads and out of order.
Break out the window executor code into its own files.
Create top-level local state objects for window execution. This will enable parallel evaluation.
Executor cleanup.
Remove the Compute method as it is vestigial.
Break out windowed aggregation evaluation state from the aggregator. More code cleanup and naming clarifications.
* Update coverage * Fix stateless DENSE_RANK setup (another victory for SVS=2)
Mytherin
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Thanks for the PR! Looks great! Unifying everything behind one interface makes everything a lot more clean.
Could we perhaps work on improving the code coverage while we're at it? A lot of these uncovered lines in window_executor.cpp are likely inherited from the previous implementation, but it might be worthwhile to have a look at covering them. Particularly those in the WindowDenseRankExecutor
Add some coverage tests.
|
Thanks! LGTM |
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly code motion for parallel window function computation, but there is concurrent work being done on the
EXCLUDEfunctionality by Romaine that relies on it.The non-trivial changes are:
DENSE_RANKrequired care.