Remove dangerous overload of cpp11::warning() #8272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Jul 17, 2023
krlmlr
pushed a commit
to krlmlr/duckdb
that referenced
this pull request
Aug 21, 2023
Remove dangerous overload of cpp11::warning()
krlmlr
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Sep 2, 2023
Remove dangerous overload of cpp11::warning()
krlmlr
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Sep 2, 2023
Remove dangerous overload of cpp11::warning()
krlmlr
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Sep 2, 2023
Remove dangerous overload of cpp11::warning()
krlmlr
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Sep 2, 2023
- Merge pull request duckdb/duckdb#8717 from Tmonster/projection_quoted_columns - Indent tests, was part of of the following PRs which otherwise cancel themselves out: - Merge pull request duckdb/duckdb#8600 from krlmlr/b-altrep-unwind: R: Fix core dump when failing to evaluate ALTREP query - Merge pull request duckdb/duckdb#8647 from krlmlr/b-altrep-cpp11-wrap: Wrap ALTREP methods with BEGIN_CPP11 and END_CPP11 - Merge pull request duckdb/duckdb#8207 from krlmlr/b-copy-string: R: Avoid crash when finalizing - Merge pull request duckdb/duckdb#8272 from krlmlr/b-warn-copy: Remove dangerous overload of cpp11::warning()
krlmlr
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Sep 2, 2023
- Merge pull request duckdb/duckdb#8717 from Tmonster/projection_quoted_columns - Indent tests, was part of of the following PRs which otherwise cancel themselves out: - Merge pull request duckdb/duckdb#8600 from krlmlr/b-altrep-unwind: R: Fix core dump when failing to evaluate ALTREP query - Merge pull request duckdb/duckdb#8647 from krlmlr/b-altrep-cpp11-wrap: Wrap ALTREP methods with BEGIN_CPP11 and END_CPP11 - Merge pull request duckdb/duckdb#8207 from krlmlr/b-copy-string: R: Avoid crash when finalizing - Merge pull request duckdb/duckdb#8272 from krlmlr/b-warn-copy: Remove dangerous overload of cpp11::warning()
krlmlr
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Sep 2, 2023
- Merge pull request duckdb/duckdb#8717 from Tmonster/projection_quoted_columns - Indent tests, was part of of the following PRs which otherwise cancel themselves out: - Merge pull request duckdb/duckdb#8600 from krlmlr/b-altrep-unwind: R: Fix core dump when failing to evaluate ALTREP query - Merge pull request duckdb/duckdb#8647 from krlmlr/b-altrep-cpp11-wrap: Wrap ALTREP methods with BEGIN_CPP11 and END_CPP11 - Merge pull request duckdb/duckdb#8207 from krlmlr/b-copy-string: R: Avoid crash when finalizing - Merge pull request duckdb/duckdb#8272 from krlmlr/b-warn-copy: Remove dangerous overload of cpp11::warning()
krlmlr
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Sep 2, 2023
- Merge pull request duckdb/duckdb#8717 from Tmonster/projection_quoted_columns - Indent tests, was part of of the following PRs which otherwise cancel themselves out: - Merge pull request duckdb/duckdb#8600 from krlmlr/b-altrep-unwind: R: Fix core dump when failing to evaluate ALTREP query - Merge pull request duckdb/duckdb#8647 from krlmlr/b-altrep-cpp11-wrap: Wrap ALTREP methods with BEGIN_CPP11 and END_CPP11 - Merge pull request duckdb/duckdb#8207 from krlmlr/b-copy-string: R: Avoid crash when finalizing - Merge pull request duckdb/duckdb#8272 from krlmlr/b-warn-copy: Remove dangerous overload of cpp11::warning()
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 5, 2023
- Merge pull request duckdb/duckdb#8717 from Tmonster/projection_quoted_columns - Indent tests, was part of of the following PRs which otherwise cancel themselves out: - Merge pull request duckdb/duckdb#8600 from krlmlr/b-altrep-unwind: R: Fix core dump when failing to evaluate ALTREP query - Merge pull request duckdb/duckdb#8647 from krlmlr/b-altrep-cpp11-wrap: Wrap ALTREP methods with BEGIN_CPP11 and END_CPP11 - Merge pull request duckdb/duckdb#8207 from krlmlr/b-copy-string: R: Avoid crash when finalizing - Merge pull request duckdb/duckdb#8272 from krlmlr/b-warn-copy: Remove dangerous overload of cpp11::warning()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes weird failuresi when unwinding, with clang. Follow-up to #8207.