Update R tests to run test_struct.R not on CRAN #8297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
reviewed
Jul 18, 2023
There was a problem hiding this comment.
Thanks for reverting the hack and putting this into proper shape. Good for me!
I am not sure what role the test_arrow_recorbatchreader.py had, pinging @pdet that according to git log put it there to check if has anything against the removal.
carlopi
approved these changes
Jul 18, 2023
|
LGTM! |
|
Thanks! |
krlmlr
pushed a commit
to krlmlr/duckdb
that referenced
this pull request
Aug 21, 2023
Update R tests to run test_struct.R not on CRAN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some issues with R tests lately. It turns out that importing the arrow library after running R relational tests can cause the R garbage collector to throw some errors. We want to avoid these errors at all costs on CRAN, but we want to run the arrow tests in our own CI. This PR re-enables running all tests in test_struct.R. In addition, it removes a python file in the R tests that isn't needed. It also adds a helper function to import the arrow library first so that this issue doesn't happen again.