Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanODBC] Fix run_nanodbc_tests.sh #8388

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented Jul 27, 2023

This file was fully hardcoded for Linux, making it impossible to use on Mac, this has been fixed.

Next to that, the sed used in it was hard to read and problematic (paths containing any / would cause the script to error)
This has been replaced with a much more readable and expressive python script.

@Tishj Tishj requested a review from maiadegraaf July 28, 2023 08:27
@Tishj Tishj marked this pull request as ready for review July 28, 2023 08:27
@github-actions github-actions bot marked this pull request as draft July 28, 2023 08:28
@Tishj Tishj marked this pull request as ready for review July 28, 2023 08:28
Copy link
Contributor

@maiadegraaf maiadegraaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@Mytherin Mytherin merged commit a1eb96a into duckdb:master Jul 28, 2023
23 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants