Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind the children of a STRUCT alias type. #8389

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented Jul 27, 2023

This PR fixes #7707

In Binder::BindLogicalType we did not bind the LogicalType we retrieved from the catalog for a USER type.
Because we didn't do that, the children of the struct type did not get bound.

If these children are also of type USER, their internal type stays INVALID which caused a crash in vector_cache.cpp

@github-actions github-actions bot marked this pull request as draft July 27, 2023 15:56
@Tishj Tishj marked this pull request as ready for review July 28, 2023 08:29
@Mytherin Mytherin merged commit cbfd87d into duckdb:master Jul 28, 2023
53 checks passed
@Mytherin
Copy link
Collaborator

Thanks! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type aliasing leads to internal error in structs with custom inner types
2 participants