[ADBC] [Python] Adding extra tests and small fixes #8431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for other Python ADBC tests
Tishj
reviewed
Jul 31, 2023
| @@ -21,6 +21,15 @@ void ArrowConverter::ToArrowArray(DataChunk &input, ArrowArray *out_array, Arrow | |||
| *out_array = appender.Finalize(); | |||
| } | |||
|
|
|||
| unsafe_unique_array<char> AddName(const string &name) { | |||
There was a problem hiding this comment.
We might be solving the same issue here, #8417
Mause
suggested changes
Jul 31, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add tests related to schema,db, connection info retrieval, and transactions (e.g., auto-commit).
I've also changed the default value of the db_schema to
main, instead of throwing an error. And fixed a bug related to returning column names on Arrow Schemas. These column names werechar*pointers owned by DuckDB Query Results in Arrow. If the query result was released before the consumption of the schema, data could be trashed.These are now properly allocated and released on the arrow release methods