Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for duplicate member tag names in serialization generation #8449

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

Maxxen
Copy link
Member

@Maxxen Maxxen commented Aug 2, 2023

Also adjust some tag names to no longer conflict within their inheritance chain.

Closes #8381

scripts/generate_serialization.py Outdated Show resolved Hide resolved
scripts/generate_serialization.py Outdated Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft August 2, 2023 13:41
@Maxxen Maxxen marked this pull request as ready for review August 2, 2023 13:41
@Mytherin
Copy link
Collaborator

Mytherin commented Aug 3, 2023

Thanks! Looks great

@Mytherin Mytherin merged commit fadff81 into duckdb:master Aug 3, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json_deserialize_sql could not round-trip parsed results from json_serialize_sql
3 participants