CAPI: Make it possible to create struct types #8455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishj
reviewed
Aug 3, 2023
Mytherin
reviewed
Aug 7, 2023
|
I added a test. |
|
@Mytherin The CI failure seems to be unrelated (Python "Extension "/project/httpfs/httpfs.duckdb_extension" version (v..1-dev) does not match DuckDB version (0.0.0)") |
|
Thanks! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C API was previously able to only create union logical types -- not structs. This PR adds support for structs as well.
Note: I used
duckdb_logical_type *instead ofduckdb_logical_typelike induckdb_create_union_type, because non-C callers of this function might not knowsizeof(duckdb::LogicalType)and so might be unable to allocate themember_typesarray. For now, I only changed the signature of this new function.