Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix query hang in Jetbrains programs (IntelliJ, DataGrip, etc) #8511

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

Mause
Copy link
Member

@Mause Mause commented Aug 8, 2023

Fixes #8489
Fixes #7631

@carlopi
Copy link
Contributor

carlopi commented Aug 8, 2023

Very much not my area, but what happens if returnsChangedRows is set, so at least logically there is work to be performed?

Say a CREATE TABLE t AS SELECT .... some lengthy calculation;.
This I think returnsNothing but still might not be trivial.

@Mause
Copy link
Member Author

Mause commented Aug 9, 2023

Very much not my area, but what happens if returnsChangedRows is set, so at least logically there is work to be performed?

Say a CREATE TABLE t AS SELECT .... some lengthy calculation;. This I think returnsNothing but still might not be trivial.

If returnsChangedRows is set, returnsNothing will not be set - they are exclusionary

@Mause Mause marked this pull request as draft August 9, 2023 06:25
@Mause Mause marked this pull request as ready for review August 10, 2023 03:31
@Mause Mause marked this pull request as draft August 10, 2023 09:52
@Mause Mause changed the title fix: return -1 from getUpdateCount() for DDL fix query hang in Jetbrains programs (IntelliJ, DataGrip, etc) Aug 10, 2023
@Mause Mause marked this pull request as ready for review August 10, 2023 14:04
@Mause Mause requested a review from hannes August 11, 2023 06:52
@hannes hannes merged commit 8c4fed7 into duckdb:master Aug 11, 2023
11 checks passed
@Mause Mause deleted the bugfix/jdbc-update-hang branch August 11, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants