Fix gcc weird behaviour around template deduction (#8533) #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishj
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Thanks, that looks like it should do the trick
emplace will forward the arguments to the pair constructor, the problem before was that it couldn't infer that BoundParameterData could be constructed from Value.
Or maybe the fact that that constructor is explicit might be the problem, either way, this looks good 👍
|
Failure is unrelated, this is good to go. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #8533, fixing a template deduction problem in older gcc compilers.
This should fix failures in nightly jobs Linux 32 bit, gcc 4.8 and Python Address Sanitizer. Tested in my fork at https://github.com/carlopi/duckdb/actions/runs/5864648533.