Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADBC: Use new(std::nothrow) + check on null #8676

Merged
merged 1 commit into from
Aug 25, 2023
Merged

ADBC: Use new(std::nothrow) + check on null #8676

merged 1 commit into from
Aug 25, 2023

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Aug 23, 2023

Previous code did plain new + check on null, but was wrong since a std::bad_alloc would have triggered a throw.

Found by CodeQL

@carlopi
ADBC: Use new(std::nothrow) + check on null
0f292f3 
Previous code did plain new + check on null, but was wrong since a std::bad_alloc would
have been thrown

Found by CodeQL
Tishj
Tishj approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's indeed an oversight 👍

@hannes hannes merged commit 63630b7 into duckdb:main Aug 25, 2023
50 of 51 checks passed
@carlopi carlopi deleted the fix_adbc branch August 28, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tishj Tishj Tishj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlopi @Tishj @hannes