Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parquet reader] support reading small decimals with DBP encoding #8715

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

samansmink
Copy link
Contributor

This adds support for small decimals that are encoded with DELTA_BINARY_PACKED encoding.

This encoding is only supported for int32 and int64, but in the case of the parquet file in the test here, the type, DECIMAL(1,0) translates to a int16 in duckdb triggering the DELTA_BINARY_PACKED should only be INT32 or INT64 warning.

This is incorrect because the switch statement looked at the duckdb type, not the parquet schema type.

@Mytherin Mytherin merged commit 931b0b7 into duckdb:main Aug 30, 2023
50 of 51 checks passed
@Mytherin
Copy link
Collaborator

Thanks! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants