[Python] DuckDB -> Pandas | NULL -> str
becomes None instead of 'NaN'
#8745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8652 and a bunch of others that raise the same issue.
Changes made:
Separated the giant file
array_wrapper.cpp
andarray_wrapper.hpp
into:raw_array_wrapper
,array_wrapper
andnumpy_result_conversion
Bundled all parameters used in the internal functions of
ArrayWrapper::Append
intoNumpyAppendData
.changed
NUMPY_T NullValue<class NUMPY_T>()
to:NUMPY_T NullValue<class NUMPY_T, bool PANDAS>(bool &set_mask)
This allows the NullValue function to be in charge of whether the mask gets set, and change behavior based on if PANDAS is set or not.
The only NullValue that has been changed for now is StringConvert, it's now:
The NumpyResultConversion has a new constructor parameter,
bool pandas = false
.This gets forwarded to the ArrayWrapper created on construction.