Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Handle SKIP_EXTENSIONS as early return in duckdb_extension_load #8781

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Sep 4, 2023

No description provided.

@github-actions github-actions bot marked this pull request as draft September 4, 2023 11:43
@carlopi carlopi marked this pull request as ready for review September 4, 2023 11:43
@carlopi carlopi changed the title [DuckDB-Wasm] Restore build by avoiding building jemalloc [Dev] Handle SKIP_EXTENSIONS as early return in duckdb_extension_load Sep 4, 2023
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@carlopi
Copy link
Contributor Author

carlopi commented Sep 4, 2023

Currently 4 failures: R was expected, CodeCoverage is independent, and the other 2 are due to a failure on github side.

Given the logic here is never actually triggered by any of these tests I think it should be ready to go.

@Mytherin Mytherin merged commit 348f592 into duckdb:main Sep 5, 2023
49 of 53 checks passed
@carlopi carlopi deleted the fix-wasm branch September 5, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants