Fix R ci #8783
Merged
Fix R ci #8783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that issue independent of the types? |
Can you be more specific? do you mean types within the data.frames/tibbles? |
|
Thanks! LGTM |
|
I believe this is an intended consequence of apache/arrow#35173. |
krlmlr
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a weird bug. I'm not sure if it relates to the new arrow version, but for some reason when comparing tibbles and data frames without explicitly casting them now fails. The problem goes away if an older arrow library is used (pre 13.0.0) or if you explicitly cast data.frames to tibbles. You can also remove explicit casts that cause test that to compare two data frames that have difference types