-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add R CMD Check workflow back for duckdb src PRs #8845
Conversation
Any notes about the platforms that this runs on? The check also takes a while >20 min, so I'm not sure if we want to run this on 3 platforms for every PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm also working on shortening the build times in duckdb-r.
shell: bash | ||
working-directory: ${{ env.DUCKDB_R_SRC }} | ||
run: ./vendor.sh | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can enable parallel builds:
- name: Build in parallel
run: |
mkdir -p ~/.R
echo 'MAKEFLAGS = -j2' >> ~/.R/Makevars
shell: bash
I think one platform (Linux?) is fine here |
@Mytherin any objections? |
LGTM |
The duckdb R package is no longer in the duckdb source. We still want to check with every PR that the duckdb R package can built with no errors. This PR will fix that by running the r-cmd-check on duckdb PRs. Tests are not run, only building the R package is checked
the workflow is as follows
R CMD build .
andR CMD check .