Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-ary lambdas, and indexes as lambda parameters #8851

Merged
merged 39 commits into from
Oct 11, 2023

Conversation

taniabogatsch
Copy link
Contributor

Before this PR, our lambda functions must always be unary, i.e., the list of lambda parameters is just a single parameter: x -> expr. This PR reworks the lambda binding functionality to allow for n-ary lambda parameters. This change lays the groundwork to support list_reduce in a future PR.

None of our lambda functions (list_transform, list_filter) require more than a single parameter. However, allowing n-ary lambdas enables supporting an index parameter to our existing lambda functions. This index parameter must always be the second parameter, containing the 1-based index of the current element in the list.

SELECT list_filter([1, 2, 1], (x, y) -> x >= y);
----
[1, 2]

SELECT list_transform([1, 2, 3], (x, x_i) -> list_transform([4, 5, 6], (y, y_i) -> x + y + x_i + y_i));
----
[[7, 9, 11], [9, 11, 13], [11, 13, 15]]

Scalar function callback

To correctly assign the types of the different lambda parameters, we need to support callbacks to the specific scalar functions. Only these functions know precisely how their parameters will look (e.g., the first parameter is the list child, and the second is UBIGINT for indexes).

Additional Notes

  • I started cleaning up the lambda code and separated functionality for list_transform and list_filter. This is only an initial refacto,r and we should pick this up in a future PR (more code separation, no more flatten, more const).
  • I added a LAMBDA_REF expression to better distinguish between column and lambda references during binding.

# Conflicts:
#	src/core_functions/lambda_functions.cpp
#	src/function/scalar_function.cpp
#	src/include/duckdb/planner/expression/bound_lambda_expression.hpp
#	src/planner/expression/bound_lambdaref_expression.cpp
#	src/storage/serialization/serialize_parsed_expression.cpp
# Conflicts:
#	src/storage/serialization/serialize_expression.cpp
@taniabogatsch taniabogatsch changed the base branch from main to feature October 2, 2023 11:20
@taniabogatsch taniabogatsch marked this pull request as ready for review October 2, 2023 11:21
@github-actions github-actions bot marked this pull request as draft October 3, 2023 11:20
@taniabogatsch taniabogatsch marked this pull request as ready for review October 3, 2023 11:20
@Mytherin Mytherin changed the base branch from feature to main October 9, 2023 12:37
@Mytherin Mytherin changed the base branch from main to feature October 9, 2023 12:37
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good - one minor comment:

src/include/duckdb/storage/serialization/expression.json Outdated Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft October 10, 2023 10:28
@taniabogatsch taniabogatsch marked this pull request as ready for review October 10, 2023 10:30
@taniabogatsch
Copy link
Contributor Author

Note to myself: these two branches have pending PRs with bug fixes after this major PR is in.

@Mytherin Mytherin merged commit 470b96a into duckdb:feature Oct 11, 2023
49 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@taniabogatsch taniabogatsch deleted the binary_lambdas branch October 12, 2023 08:13
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 11, 2023
Merge pull request duckdb/duckdb#9164 from Mause/feature/jdbc-uuid-param
Merge pull request duckdb/duckdb#9185 from pdet/adbc_07
Merge pull request duckdb/duckdb#9126 from Maxxen/parquet-kv-metadata
Merge pull request duckdb/duckdb#9123 from lnkuiper/parquet_schema
Merge pull request duckdb/duckdb#9086 from lnkuiper/json_inconsistent_structure
Merge pull request duckdb/duckdb#8977 from Tishj/python_readcsv_multi_v2
Merge pull request duckdb/duckdb#9279 from hawkfish/nsdate-cast
Merge pull request duckdb/duckdb#8851 from taniabogatsch/binary_lambdas
Merge pull request duckdb/duckdb#8983 from Maxxen/types/fixedsizelist
Merge pull request duckdb/duckdb#9318 from Maxxen/fix-unused
Merge pull request duckdb/duckdb#9220 from hawkfish/exclude
Merge pull request duckdb/duckdb#9230 from Maxxen/json-plan-serialization
Merge pull request duckdb/duckdb#9011 from Tmonster/add_create_statement_support_to_fuzzer
Merge pull request duckdb/duckdb#9400 from Maxxen/array-fixes
Merge pull request duckdb/duckdb#8741 from Tishj/python_import_cache_upgrade
Merge fixes
Merge pull request duckdb/duckdb#9395 from taniabogatsch/lambda-performance
Merge pull request duckdb/duckdb#9427 from Tishj/python_table_support_replacement_scan
Merge pull request duckdb/duckdb#9516 from carlopi/fixformat
Merge pull request duckdb/duckdb#9485 from Maxxen/fix-parquet-serialization
Merge pull request duckdb/duckdb#9388 from chrisiou/issue217
Merge pull request duckdb/duckdb#9565 from Maxxen/fix-array-vector-sizes
Merge pull request duckdb/duckdb#9583 from carlopi/feature
Merge pull request duckdb/duckdb#8907 from cryoEncryp/new-list-functions
Merge pull request duckdb/duckdb#8642 from Virgiel/capi-streaming-arrow
Merge pull request duckdb/duckdb#8658 from Tishj/pytype_optional
Merge pull request duckdb/duckdb#9040 from Light-City/feature/set_mg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants