[Python] Add 'names' option to read_csv
#8967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8857
The PR also mentions
auto_detect
but that isn't supported.read_csv
will always auto detect currently.We add support for the
names
parameter, as anOptional[List[str]]
, and this plays nicely with the existingdtype
parameter.Misc:
This PR also fixes a slight bug in
dtype
, as it cast the type parameter toDuckDBPyType
but then didn't use this result, instead it just usedstr(type)
, which madedtype
fail if anything other than astr | DuckDBPyType
was provided.Now things like
int
andstr
which can be implicitly cast to DuckDBPyType also work i.e