Truncate the db file before the WAL for differential storage #8980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential relies on the signal of the WAL file being truncated to snapshot the differential file. It would be helpful to have db truncations occur before hand - so we can capture this in our snapshot.
The ordering of these operations (WAL vs DB truncation) do not affect correctness - as the database should be durable after the table_metadata_writer->Flush() completes. At this point - DuckDB is just cleaning up the database/WAL state at the end of the checkpoint.