Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Trigger R.yml only only if there are changes to R.yml itself #9304

Merged
merged 1 commit into from Oct 15, 2023

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Oct 11, 2023

R.yml is otherwise triggered on every merge commit to main, seems noisy.

Idea is that it will trigger on PRs only when modifying itself (just to check consistency).

@Mytherin
Copy link
Collaborator

Thanks! Perhaps this could instead be triggered only in PRs and in nightly test runs, just like all other workflows?

@carlopi
Copy link
Contributor Author

carlopi commented Oct 13, 2023

I think this is what should happen after this PR:
manual workflow trigger or repository trigger have this run (as before)
PR have this run if the R.yml file itself is changed, but otherwise default is no runs on PRs.

This last part can also go away, and saying it should run only on explicit triggers.

@Mytherin
Copy link
Collaborator

Shouldn't it also run on PRs? It seems the run was skipped for this PR

@carlopi
Copy link
Contributor Author

carlopi commented Oct 13, 2023

I think that this PR gets evaluated against current main branch yml files, and they are all not triggered (R.yml file since it misses a section on pull_request and the other since they corrently have R.yml in their ignore list).

The idea would be that, after this is merged, any subsequent PR changing R.yml should trigger a workflow.

@Mytherin Mytherin merged commit 01adbca into duckdb:main Oct 15, 2023
1 check passed
@carlopi carlopi deleted the fixr branch October 16, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants