[ADBC] Add support for windows. #9357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mause
suggested changes
Oct 16, 2023
|
@Mytherin Is this good to go? edit: apparently got a merge conflict, doing that now. |
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9357 from pdet/adbc_windows Merge pull request duckdb/duckdb#9903 from Mytherin/cifixesagain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the dllexport/import attributes to the adbc_init function.
It also includes adaptations to the CI process, enabling the execution of ADBC tests on both the Windows and Python-Windows CIs.
Some adjustments were made to the CPP tests, primarily involving path creation for test databases and connection initialization.