Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reset validity target count #9565

Merged
merged 3 commits into from Nov 6, 2023
Merged

Don't reset validity target count #9565

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aeecec
dont reset target count
Maxxen Nov 3, 2023
60d2368
actually resize after reset instead
Maxxen Nov 3, 2023
a568f68
only resize if needed
Maxxen Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/common/types/vector_cache.cpp
View file
Open in desktop
Expand Up @@ -77,6 +77,10 @@ class VectorCacheBuffer : public VectorBuffer {
auto &child_cache = child_caches[0]->Cast<VectorCacheBuffer>();
auto &array_child = result.auxiliary->Cast<VectorArrayBuffer>().GetChild();
child_cache.ResetFromCache(array_child, child_caches[0]);

// Ensure the child validity is (will be) large enough, even if its not initialized.
auto validity_target_size = array_child.validity.TargetCount();
array_child.validity.Resize(validity_target_size, std::max(validity_target_size, child_cache.capacity));
break;
}
case PhysicalType::STRUCT: {
Expand Down