Internal #576: strptime strftime infinities #9615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it so we can round trip infinite temporal values through the datetime parser and formatter. This now differs from PG but I think they are wrong. fixes: duckdblabs/duckdb-internal#576
|
Rebasing required deleting the old branch and PR - sorry! |
Mytherin
reviewed
Nov 9, 2023
CR feedback: Precheck for specials' leading characters to avoid multiple strcmp passes on every parsed value.
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 11, 2023
Merge pull request duckdb/duckdb#9392 from lnkuiper/parquet_encryption Merge pull request duckdb/duckdb#9461 from hawkfish/merge-sort-trees Merge pull request duckdb/duckdb#8788 from alnkesq/capi_create_enum_type Merge pull request duckdb/duckdb#9513 from Tmonster/5614-database-invalidated Merge pull request duckdb/duckdb#9622 from Mytherin/typescoping Merge pull request duckdb/duckdb#9615 from hawkfish/strptime-infinity Merge pull request duckdb/duckdb#9627 from Mytherin/attachifnotexists Merge pull request duckdb/duckdb#9648 from samansmink/add-keep-alive-toggle Merge pull request duckdb/duckdb#9638 from taniabogatsch/bench-refactor Merge pull request duckdb/duckdb#9651 from Mytherin/getenv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so we can round trip infinite temporal values through the datetime parser and formatter.
This now differs from PG but I think they are wrong.
fixes: duckdblabs/duckdb-internal#576