Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/9768 #9791

Merged
merged 2 commits into from Nov 24, 2023
Merged

Bugfix/9768 #9791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78115aa
test: add failing test of #9768
nbc Nov 24, 2023
e8f51ce
allow empty string for partitions. fixes #9768
nbc Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file added data/parquet-testing/hive-partitioning/empty_string/key=/part-0.parquet
View file
Open in desktop
Binary file not shown.
Binary file added data/parquet-testing/hive-partitioning/empty_string/key=a/part-0.parquet
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/common/hive_partitioning.cpp
View file
Open in desktop
Expand Up @@ -65,7 +65,7 @@ static void ConvertKnownColRefToConstants(unique_ptr<Expression> &expr,
// - http(s)://domain(:port)/lala/kasdl/var1=value1/?not-a-var=not-a-value
// - folder/folder/folder/../var1=value1/etc/.//var2=value2
const string &HivePartitioning::RegexString() {
static string REGEX = "[\\/\\\\]([^\\/\\?\\\\]+)=([^\\/\\n\\?\\\\]+)";
static string REGEX = "[\\/\\\\]([^\\/\\?\\\\]+)=([^\\/\\n\\?\\\\]*)";
return REGEX;
}

Expand Down
14 changes: 14 additions & 0 deletions test/sql/copy/parquet/parquet_hive_empty.test
View file
Open in desktop
@@ -0,0 +1,14 @@
# name: test/sql/copy/parquet/parquet_hive_empty.test
# description: Test empty partitioning values
# group: [parquet]

require parquet

query II
select *
from parquet_scan('data/parquet-testing/hive-partitioning/empty_string/*/*.parquet', hive_partitioning=1)
ORDER BY ALL
----
a a
b (empty)