Fix #9863 - avoid moving constants for DATE - DATE subtractions #9874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkfish
approved these changes
Dec 2, 2023
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9874 from Mytherin/issue9863
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9863
The issue here is that the
MoveConstantsoptimizer assumes that an arithmetic operation returns the same type as the type of its inputs (i.e.INT32 - INT32 = INT32). This is true for (integer) numbers but is not correct for dates -DATE - DATEreturnsBIGINT(i.e.INT32 - INT32 = INT64). This broken assumption then causes an invalid plan to be generated that leads to a comparison between anINT32and anINT64, which causes strange behavior.