add FROM to InitialKeywords vector in autocomplete extension
#9877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamilton
changed the title
InitialKeywords vector in autocomplete extension
|
Thanks! LGTM |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9872 from Tishj/regexp_matches_null_optimizer Merge pull request duckdb/duckdb#9877 from hamilton/hamilton/autocomplete-add-from-to-initial-keywords Merge pull request duckdb/duckdb#9875 from Mytherin/progressbardisable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small patch to the autocomplete library, adding
FROMto the list of expected initial keywords. In other words, if I writeFROM sql_auto_complete('FRO')I should expect to get backFROM.Adds a test case for this in
tools/shell/tests/test_autocomplete.py.I haven't made a patch to this part of duckdb before so please let me know if I've made a mistake!