Make IEJoin code more clear #9973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkfish
approved these changes
Dec 13, 2023
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 15, 2023
Merge pull request duckdb/duckdb#10005 from Tishj/python3_7_optional_issue Merge pull request duckdb/duckdb#9974 from taniabogatsch/duplicate-lambda-parameters Merge pull request duckdb/duckdb#9999 from Mytherin/parallelcheckpoint Merge pull request duckdb/duckdb#9973 from xuke-hat/refine-iejoin Merge pull request duckdb/duckdb#9984 from hawkfish/tsns-time Merge pull request duckdb/duckdb#9977 from atacan/swift-readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lhs_ordersandrhs_orderswerevector<vector<BoundOrderByNode>>but each vector only contained one element. It's better to usevector<BoundOrderByNode>instead.JoinComplexBlocksthe checkif (lrid > 0 && rrid < 0)is unnecessary.IEJoinUnion::NextRow()lridis ensured to be positiverrid = li[j],bit_mask[j]is valid andbit_mask[j]is only set whenli[j] < 0.