Avoid workaround with dev vctrs

r-lib/vctrs#1847
duckdblabs · Jun 7, 2023 · b15f598 · b15f598
1 parent 64a389e
commit b15f598
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -31,7 +31,7 @@ Imports:
     tibble,
     tidyselect,
     utils,
-    vctrs
+    vctrs (>= 0.6.2.9000)
 Suggests: 
     arrow,
     constructive,
@@ -49,3 +49,5 @@ RoxygenNote: 7.2.3
 Config/testthat/edition: 3
 Config/testthat/parallel: false
 Config/testthat/start-first: as_duckplyr_df, mutate, filter, count-tally
+Remotes: 
+    r-lib/vctrs#1847
diff --git a/NAMESPACE b/NAMESPACE
@@ -141,6 +141,7 @@ importFrom(dplyr,desc)
 importFrom(dplyr,distinct)
 importFrom(dplyr,do)
 importFrom(dplyr,dplyr_col_modify)
+importFrom(dplyr,dplyr_reconstruct)
 importFrom(dplyr,dplyr_row_slice)
 importFrom(dplyr,explain)
 importFrom(dplyr,filter)

diff --git a/R/dplyr_reconstruct.R b/R/dplyr_reconstruct.R
@@ -1,9 +1,7 @@
 # Generated by 02-duckplyr_df-methods.R
 
-# Avoid harmful stripping of attributes in base implementation
-dplyr_reconstruct <- function(data, template) {
-  UseMethod("dplyr_reconstruct", template)
-}
+#' @importFrom dplyr dplyr_reconstruct
+NULL
 
 #' @export
 dplyr_reconstruct.data.frame <- function(data, template) {