Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: New ext_install() #100

Closed
wants to merge 6 commits into from
Closed

chore: New ext_install() #100

wants to merge 6 commits into from

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Feb 28, 2024

use rfuns extension to implement equality,

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 9.71%. Comparing base (7407b03) to head (e940bdf).

❗ Current head e940bdf differs from pull request most recent head 730e3af. Consider uploading reports for the commit 730e3af to get more accurate results

Files Patch % Lines
R/ext.R 0.00% 5 Missing ⚠️
R/meta.R 85.71% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #100      +/-   ##
========================================
+ Coverage   9.66%   9.71%   +0.04%     
========================================
  Files        127     128       +1     
  Lines      22633   22654      +21     
========================================
+ Hits        2187    2200      +13     
- Misses     20446   20454       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 15, 2024

@romainfrancois: The extension can be installed on Windows with duckdb 0.10.0, yay!

@krlmlr krlmlr marked this pull request as draft March 15, 2024 16:04
@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 15, 2024

This remains a draft until after duckplyr 0.3.2 has hit CRAN.

@krlmlr
Copy link
Collaborator Author

krlmlr commented May 5, 2024

Closing in favor of #148.

@krlmlr krlmlr closed this May 5, 2024
@krlmlr
Copy link
Collaborator Author

krlmlr commented May 16, 2024

CC @romainfrancois.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants