feat: library(duckplyr) calls methods_overwrite()
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavisVaughan: Do you see issues with this way of overwriting and talking about it? Is there value in rearranging the two howto sections in the README? |
krlmlr
force-pushed
the
f-overwrite-on-attach
branch
from
279b83a
to
038d9ab
Compare
DavisVaughan
approved these changes
May 14, 2024
There was a problem hiding this comment.
Seems good like this, I think the readme ordering is right (less to more aggressive in terms of how to use the package).
What happens if you library(duckplyr) and then library(dplyr)? Maybe that's not a problem since we Import dplyr, and it always at least gets loaded first?
krlmlr
commented
May 16, 2024
krlmlr
force-pushed
the
f-overwrite-on-attach
branch
from
4a7ab3b
to
eadc52c
Compare
Co-authored-by: Davis Vaughan <davis@posit.co>
krlmlr
force-pushed
the
f-overwrite-on-attach
branch
from
eadc52c
to
b43e76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.