Make Duckplyr_df from csv more generic so it can be from json, parquet, csv et.c #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Merging is fine at this stage, it's not accessed by any tests or anything. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge until duckdb/duckdb#7823 is merged.
DuckDB relational api now exposes all table functions so if the user can specify the function and options that might be nicer. Then we don't have to update dplyr every time duckdb adds a new table function.
the query
from duckdb_functions() where function_type like '%table%' and (function_name like '%read%' or function_name like '%scan%');in duckdb shows that there are a number of functions that could be used to read different file formats, (namely json, csv, parquet).Open to different ideas/implementations for this.