Skip to content

Commit

Permalink
Merge branch 'release/5.84.2' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
CDRussell committed Apr 28, 2021
2 parents 61cebdf + 74cf57f commit 4b0de61
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 16 deletions.
2 changes: 1 addition & 1 deletion app/version/version.properties
@@ -1 +1 @@
VERSION=5.84.1
VERSION=5.84.2
21 changes: 18 additions & 3 deletions fastlane/Fastfile
Expand Up @@ -20,6 +20,8 @@ platform :android do
desc "Upload APK to Play Store"
lane :deploy_playstore do

update_fastlane_release_notes()

props = property_file_read(file: "app/version/version.properties")
version = props["VERSION"]
apkPath = "app/build/outputs/apk/play/release/duckduckgo-#{version}-play-release.apk"
Expand All @@ -28,8 +30,12 @@ platform :android do
apk: apkPath,
track: 'internal',
skip_upload_screenshots: true,
skip_upload_images: true
skip_upload_images: true,
validate_only: false
)

cleanup_fastlane_release_notes()

end

desc "Upload APK to ad-hoc internal app sharing"
Expand Down Expand Up @@ -79,6 +85,17 @@ platform :android do

end

desc "Clean up local changelist metadata"
lane :cleanup_fastlane_release_notes do

flversion=gradle(task: '-q fastlaneVersionCode')
UI.message("Fastlane version is #{flversion}.")

sh("rm '../fastlane/metadata/android/en-US/changelogs/#{flversion}.txt'")
sh("rm '../fastlane/metadata/android/en-GB/changelogs/#{flversion}.txt'")

end

# Note, this currently relies on having `git flow` tools installed.
# This dependency could be removed with a little more time to tidy up this script to do the branching/merging manually.

Expand Down Expand Up @@ -122,8 +139,6 @@ platform :android do
You can always reach us at https://duckduckgo.com/feedback.""")
end

update_fastlane_release_notes()

if UI.confirm(text:"If you have any other changes to make to the release branch, do them now. Enter `y` when ready to create and push tags")

git_commit(path: "*", message: "Updated release notes and version number for new release - #{newVersion}")
Expand Down
5 changes: 5 additions & 0 deletions fastlane/README.md
Expand Up @@ -36,6 +36,11 @@ Deploy APK to GitHub
fastlane android update_fastlane_release_notes
```
Update local changelist metadata
### android cleanup_fastlane_release_notes
```
fastlane android cleanup_fastlane_release_notes
```
Clean up local changelist metadata
### android release
```
fastlane android release
Expand Down
6 changes: 0 additions & 6 deletions fastlane/metadata/android/en-GB/changelogs/58100.txt

This file was deleted.

6 changes: 0 additions & 6 deletions fastlane/metadata/android/en-US/changelogs/58100.txt

This file was deleted.

0 comments on commit 4b0de61

Please sign in to comment.