Skip to content

Commit

Permalink
ADS: Add a custom CardView for DaxDialogs (#2550)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1202857801505092/1203425281067996

### Description
The top triangle in the DaxDialog doesn't respect elevation. The outline
around it is not consistent with the rest of the Card.

### UI changes

| Before  | After |
| ------ | ----- |

![Screenshot_20221122_174516](https://user-images.githubusercontent.com/531613/203578300-1a80b73e-cb28-441c-831c-cb9a1307319f.png)|![Screenshot_20221123_140401](https://user-images.githubusercontent.com/531613/203578315-8778a408-8158-40f3-ae88-d1bc3039937a.png)|
  • Loading branch information
malmstein authored and aitorvs committed Dec 19, 2022
1 parent d2f8081 commit a7aa6b1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions common-ui/src/main/res/values/design-system-dimensions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,5 @@
<!-- Card -->
<dimen name="daxBubbleDialogDistanceFromEdge">22dp</dimen>
<dimen name="daxBubbleDialogEdge">9dp</dimen>

</resources>

0 comments on commit a7aa6b1

Please sign in to comment.