Pre release autofill #1274
Merged
Pre release autofill #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/marcos/pre-release-autofill � Conflicts: � app/src/androidTest/java/com/duckduckgo/app/settings/SettingsViewModelTest.kt � app/src/main/java/com/duckduckgo/app/email/db/EmailDataStore.kt � app/src/main/java/com/duckduckgo/app/email/di/EmailModule.kt � app/src/main/java/com/duckduckgo/app/settings/SettingsActivity.kt � app/src/main/java/com/duckduckgo/app/settings/SettingsViewModel.kt
cmonfortep
reviewed
Jun 9, 2021
There was a problem hiding this comment.
Code review is done, GJ @marcosholgado, everything was really well structured.
I'm going to start testing this now, so I will approve the PR once I ensure everything works as expected. However, sending to you some minor comments. Thanks.
app/src/main/java/com/duckduckgo/app/beta/BetaFeaturesActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/email/ui/EmailProtectionActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/email/ui/EmailProtectionViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/email/ui/EmailProtectionViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/notification/NotificationSender.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/email/waitlist/WaitlistWorkRequestBuilder.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/email/ui/EmailProtectionSignOutViewModelTest.kt
Show resolved
Hide resolved
…feature/marcos/pre-release-autofill � Conflicts: � app/src/main/res/values/themes.xml � common-ui/src/main/res/values/attrs.xml
…feature/marcos/pre-release-autofill � Conflicts: � app/src/main/java/com/duckduckgo/app/settings/SettingsActivity.kt � app/src/main/java/com/duckduckgo/app/settings/SettingsViewModel.kt
cmonfortep
reviewed
Jun 21, 2021
app/src/main/java/com/duckduckgo/app/email/ui/EmailProtectionSignOutViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/email/ui/EmailProtectionFragment.kt
Show resolved
Hide resolved
| setClickableSpan(binding.emailPrivacyDescription, R.string.emailProtectionDescriptionJoin, listOf(readBlogSpan)) | ||
| } | ||
|
|
||
| private val getNotificationSpan = object : NonUnderlinedClickableSpan() { |
There was a problem hiding this comment.
should all these val be at the top of the file?
| ~ limitations under the License. | ||
| --> | ||
|
|
||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
There was a problem hiding this comment.
SettingsPillWithSubtitle is already a LinearLayout, you can use merge and remove another nested linearlayout here.
cmonfortep
approved these changes
Jun 21, 2021
samsymons
reviewed
Jun 22, 2021
…feature/marcos/pre-release-autofill
Merged
# Conflicts: # app/src/androidTest/java/com/duckduckgo/app/settings/SettingsViewModelTest.kt # app/src/main/java/com/duckduckgo/app/settings/SettingsActivity.kt # app/src/main/java/com/duckduckgo/app/settings/SettingsViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/inbox/1125189844075764/1200425975637284/1200442170423677
Tech Design URL:
CC:
Description:
This PR adds the pre-release features for autofill
Steps to test this PR:
Test cases are in the Asana task
Internal references:
Software Engineering Expectations
Technical Design Template