Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1649

Merged
merged 1 commit into from Jan 6, 2022
Merged

Update dependencies #1649

merged 1 commit into from Jan 6, 2022

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Jan 6, 2022

Task/Issue URL: https://app.asana.com/0/414730916066338/1201617772632569/f

Description

⬆️ Updates the following dependencies:

  • version.androidx.room=2.4.0-beta02 → 2.4.0
  • version.com.airbnb.android..lottie=4.2.1 → 4.2.2
  • version.google.dagger=2.38.1 → 2.40.5
  • version.kotlinx.coroutines=1.6.0-RC3 → 1.6.0
  • version.leakcanary=2.7 → 2.8
  • version.okhttp3=4.9.1 → 4.9.3
  • version.robolectric=4.7.2 → 4.7.3
  • version.com.jakewharton.threetenabp..threetenabp=1.3.0 → 1.3.1
  • version.org.threeten..threetenbp=1.4.5 → 1.5.2
  • version.com.facebook.flipper..flipper=0.96.1 → 0.127.0
  • version.com.facebook.soloader..soloader=0.10.1 → 0.10.3

❌ Removes (No longer referenced):

  • version.androidx.test.core=1.4.0
  • version.androidx.work..work-multiprocess=2.7.1
  • version.androidx.security=1.1.0-alpha03
  • version.org.mockito..mockito-android=4.2.0
  • version.androidx.viewpager2..viewpager2=1.0.0
  • version.androidx.test.espresso..espreso-core=3.4.0
  • version.androidx.test.ext..junit-ktx=1.1.3
  • version.androidx.core..core-ktx=1.6.0

Steps to test this PR

  1. All unit tests should pass.
  2. Run through the app and check that there isn't any unexpected behavior.

Smoke test:

  • Onboarding CTAs
  • Add bookmarks and favorites
  • Disable/enable privacy protection
  • Share feedback
  • Fireproof a site and clear all data
  • Opening multiple tabs (and closing tabs + undo)
  • Enable App Tracking Protection

I tested on API 21, 26 and 30.

@joshliebe joshliebe marked this pull request as ready for review January 6, 2022 13:59
@anikiki anikiki self-assigned this Jan 6, 2022
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested on API 31 and works as expected 🎉

@joshliebe
Copy link
Contributor Author

Looks good! Tested on API 31 and works as expected 🎉

Thanks @anikiki!

@joshliebe joshliebe merged commit fbcef2b into develop Jan 6, 2022
@joshliebe joshliebe deleted the feature/josh/update-dependencies branch January 6, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants