Update html/js libraries via npm #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonfortep
commented
Jun 9, 2022
app/build.gradle
Outdated
| @@ -36,7 +36,7 @@ android { | |||
| main { | |||
| java { | |||
| resources { | |||
| srcDirs += files("$projectDir/../submodules/autofill/dist/".toString()) | |||
| srcDirs += "$projectDir/../node_modules/@duckduckgo/autofill/dist/".toString() | |||
There was a problem hiding this comment.
This will ensure only files inside /dist will be included when we build the app.
cmonfortep
commented
Jun 9, 2022
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "dependencies": { | ||
| "@duckduckgo/autofill": "github:duckduckgo/duckduckgo-autofill#4.6.0" |
There was a problem hiding this comment.
Here's where we will change the library versions.
cmonfortep
commented
Jun 9, 2022
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 16.x | ||
| - name: Npm update |
There was a problem hiding this comment.
This Github Action will run npm and autocommit the changes.
|
@cmonfortep I just switched to autofill v4.6.0 and created a merge conflict for you. You'll need to resolve it on your branch even though that's going to be removed |
# Conflicts: # submodules/autofill
CDRussell
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1202412970169527/f
Description
Proposal to stop using submodules for html/js libraries.
As a first test, we will migrate autofill to the new approach.
Steps to test this PR
Ensure autofill works
Manual npm update
npm updatenode_moduleshave been updatedValidate your IDE don't show the submodule anymore
UI changes