Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle Wrapper files #4277

Merged

Conversation

ed-george
Copy link
Contributor

@ed-george ed-george commented Mar 10, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1206802291620656/f

Description

Fixes #4276

Adds expected files for Gradle Wrapper 8.2 from calling gradlew wrapper task:

./gradlew wrapper --gradle-version=8.2 --distribution-type=bin --gradle-distribution-sha256-sum=38f66cd6eef217b4c35855bb11ea4e9fbc53594ccccb5fb82dfd317ef8c2c5a3

Additionally adds Gradle distro verification via checksum

Steps to test this PR

  • Verify application builds correctly and downloads Gradle Wrapper with expected checksum

UI changes

  • N/A

@joshliebe joshliebe self-assigned this Mar 12, 2024
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ed-george!

This is a worthwhile addition, thanks for this 🙂

I made the same change on a separate branch just to verify everything, LGTM!

@joshliebe joshliebe merged commit cd1c494 into duckduckgo:develop Mar 12, 2024
4 of 7 checks passed
@asos-edgeorge
Copy link

Nice one 💪

@ed-george ed-george deleted the fix/ed-george/gradle-wrapper branch March 24, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Gradle Wrapper files do not match version supplied in gradle-wrapper.properties
3 participants