Translations for new delete-passwords copy #4446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CDRussell and the rest of your teammates on |
26 tasks
CDRussell
force-pushed
the
feature/craig/update_copy_when_deleting_passwords_based_on_sync_enabled_state
branch
from
c06f265
to
e4d11bf
Compare
CDRussell
force-pushed
the
feature/craig/update_copy_when_deleting_passwords_based_on_sync_enabled_state_l10n
branch
from
2d78288
to
b5aa293
Compare
CDRussell
force-pushed
the
feature/craig/update_copy_when_deleting_passwords_based_on_sync_enabled_state
branch
from
e4d11bf
to
40f9c15
Compare
CDRussell
force-pushed
the
feature/craig/update_copy_when_deleting_passwords_based_on_sync_enabled_state
branch
from
40f9c15
to
84ffbfe
Compare
Translate strings-autofill-impl to values-fr Translate strings-autofill-impl to values-es
Translate strings-autofill-impl to values-cs
CDRussell
force-pushed
the
feature/craig/update_copy_when_deleting_passwords_based_on_sync_enabled_state_l10n
branch
from
b5aa293
to
f2ffc7f
Compare
Translate strings-autofill-impl to values-nl Translate strings-autofill-impl to values-it Translate strings-autofill-impl to values-ro Translate strings-autofill-impl to values-sk Translate strings-autofill-impl to values-sv Translate strings-autofill-impl to values-bg Translate strings-autofill-impl to values-fr Translate strings-autofill-impl to values-sl Translate strings-autofill-impl to values-lt Translate strings-autofill-impl to values-el Translate strings-autofill-impl to values-pt Translate strings-autofill-impl to values-et Translate strings-autofill-impl to values-nb Translate strings-autofill-impl to values-de Translate strings-autofill-impl to values-ru Translate strings-autofill-impl to values-tr Translate strings-autofill-impl to values-hu Translate strings-autofill-impl to values-fi Translate strings-autofill-impl to values-lv Translate strings-autofill-impl to values-pl Translate strings-autofill-impl to values-da Translate strings-autofill-impl to values-es Translate strings-autofill-impl to values-cs
CDRussell
force-pushed
the
feature/craig/update_copy_when_deleting_passwords_based_on_sync_enabled_state
branch
from
84ffbfe
to
8b44e53
Compare
|
Translations got messy here; will close PR and open a new clean one |
CDRussell
added a commit
that referenced
this pull request
May 28, 2024
…or not (#4445) Task/Issue URL: https://app.asana.com/0/488551667048375/1206638124888258/f ### Description Copy changes around deleting passwords (now showing a different message when sync is enabled vs disabled). Translations will come in #4446 # Steps to test this PR ## Sync Disabled ### single saved password - [ ] Disable sync (or leave it disabled if off already) - [ ] Visit password management screen (overflow -> passwords) - [ ] Add a single saved password (so you only have 1 total). - [ ] Return to password management screen - [ ] Then choose overflow -> Delete All Passwords - [ ] Verify the dialog title is **Are you sure you want to delete this password?** - [ ] Verify the dialog message says "password" (singular) and "account" (singular) - [ ] Verify the dialog message says it'll be "deleted from this device" - [ ] Cancel the prompt. Click on the overflow of the saved password, and choose **Delete**. Ensure the last two checks you just did are still valid for this scenario. ### multiple saved passwords - [ ] Add a second saved password (so you now have 2 total), and return to password management screen - [ ] Then choose overflow -> Delete All Passwords - [ ] Verify the dialog title is **Are you sure you want to delete 2 passwords** - [ ] Verify the dialog message says "password**s**" and "account**s**" - [ ] Verify the dialog message says it'll be "deleted from this device" ## Sync Enabled ### multiple saved passwords - [ ] Enable sync - [ ] Visit password management screen (overflow -> passwords). Ensure you have > 1 saved password. - [ ] Then choose overflow -> Delete All Passwords - [ ] Verify the dialog title is **Are you sure you want to delete 2 passwords** - [ ] Verify the dialog message says "password**s**" and "account**s**" - [ ] Verify the dialog message says it'll be "deleted from all synced devices" ### single saved password - [ ] Enable sync - [ ] Visit password management screen (overflow -> passwords). Ensure you have exactly 1 saved password. - [ ] Then choose overflow -> Delete All Passwords - [ ] Verify the dialog title is **Are you sure you want to delete this password?** - [ ] Verify the dialog message says "password" (singular) and "account" (singular) - [ ] Verify the dialog message says it'll be "deleted from all synced devices"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207137389393798/f
Description
Translations for copy changes around deleting passwords (now showing a different message when sync is enabled vs disabled)
Steps to test this PR