-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Extended Onboarding to all users #4583
Release Extended Onboarding to all users #4583
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
93bcae0
to
b540737
Compare
@@ -453,7 +447,7 @@ open class BrowserActivity : DuckDuckGoActivity() { | |||
} | |||
dialog.setOnShowListener { currentTab?.onFireDialogVisibilityChanged(isVisible = true) } | |||
dialog.setOnCancelListener { | |||
pixel.fire(if (dialog.ctaVisible) FIRE_DIALOG_PROMOTED_CANCEL else FIRE_DIALOG_CANCEL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to keep the FIRE_DIALOG_PROMOTED_CANCEL
constant in the code? I see it's not used anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I'll remove it
…ureToggles for the CTAs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected! 🎉
213ce68
to
4298307
Compare
4298307
to
126c541
Compare
Task/Issue URL: https://app.asana.com/0/1201807753394693/1207407312592960/f
Description
Remove old onboarding and release new extended onboarding to all users
Steps to test this PR
Pre onboarding
Search suggestions dialog
SERP Dax dialog
Site suggestions Dax dialog
Got it!
buttonSurprise me!
optionbritannica.com/animal/duck
...
Trackers Blocked Dax dialog
Got it!
button...
Fire Button Dax dialog
...
End onboarding dialog
...
No Trackers Dax dialog
wikipedia.org
...
Trackers Network Dax dialog
instagram.com
UI changes
extended_onboarding_flow.1.mp4